[PATCH] D19570: [PDB] Parse module information from the DBI stream

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 18:59:09 PDT 2016


ruiu added a comment.

I'd personally prefer adding padding field because it is explicit and it is I believe more common than implicit padding when describing data structure in file.

By the way, we don't care about endianness of padding, so I think

  uint8_t Pad1[4];

is more common than

  ulittle16_t Pad1;


http://reviews.llvm.org/D19570





More information about the llvm-commits mailing list