[PATCH] D19571: [PDB] Fix function names for private symbols in PDBs

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 17:02:15 PDT 2016


zturner added inline comments.

================
Comment at: lib/DebugInfo/PDB/PDBContext.cpp:113-114
@@ +112,4 @@
+      // linkage name while the function does not.
+      if (!Func || (Func->getAddressSection() == PS->getAddressSection() &&
+                    Func->getAddressOffset() == PS->getAddressOffset()))
+        return PS->getName();
----------------
Use `getVirtualAddress()` or `getRelativeVirtualAddress()` here to simplify this conditional.


http://reviews.llvm.org/D19571





More information about the llvm-commits mailing list