[PATCH] D19490: ELF: Move code to where it is used, and related cleanups. NFC.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 16:44:49 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: ELF/ICF.cpp:250
@@ -260,1 +249,3 @@
+    SymbolBody &SA = A->File->getRelocTargetSym(*(const Elf_Rel *)IA);
+    SymbolBody &SB = B->File->getRelocTargetSym(*(const Elf_Rel *)IB);
     if (&SA == &SB)
----------------
Do you really need the cast?

================
Comment at: ELF/InputFiles.h:132
@@ +131,3 @@
+    uint32_t SymIndex = Rel.getSymbol(Config->Mips64EL);
+    return getSymbolBody(SymIndex).repl();
+  }
----------------
I moved the repl to geSymbolBody. Please remember to drop it here when you merge.


http://reviews.llvm.org/D19490





More information about the llvm-commits mailing list