[PATCH] D19435: [LowerExpectIntrinsic] make default likely/unlikely ratio bigger

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 14:27:14 PDT 2016


davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm.


================
Comment at: lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:42
@@ +41,3 @@
+// only be used in extreme cases, we could make this ratio higher. As it stands,
+// programmers may be using __builtin_expect() as a substitute for actual
+// profile data.
----------------
'substitute as actual ...' --> use it to annotate that the branch is likely/unlikely to be taken.


http://reviews.llvm.org/D19435





More information about the llvm-commits mailing list