[PATCH] D19338: New code hoisting pass based on GVN (optimistic approach)

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 11:37:15 PDT 2016


sebpop added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:396
@@ +395,3 @@
+    VNtoInsns VNtoLoads;
+    for (BasicBlock &BB : F) {
+      for (Instruction &I1 : BB) {
----------------
Replacing the iteration over all the BBs of the function with a depth_first iteration fixes the infinite recursion problem reported by Brendon:

    for (BasicBlock *BB : depth_first(&F.getEntryBlock()))



http://reviews.llvm.org/D19338





More information about the llvm-commits mailing list