[PATCH] D18762: Add Aggressive Control Dead Code Elimination

Z. Zheng via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 11:11:08 PDT 2016


zzheng added a subscriber: zzheng.
zzheng added a comment.

Just some drive-by nitpicks on format: acdec.[h|cpp] files' banner and 80 columns. Please comply with coding standard.


================
Comment at: include/llvm/Transforms/Scalar.h:86
@@ -85,1 +85,3 @@
 //
+// AggressiveControlDCE - This pass uses the SSA based Aggressive DCE algorithm.  This
+// algorithm assumes instructions are dead until proven otherwise, which makes
----------------
Exceeds 80 columns.

================
Comment at: include/llvm/Transforms/Scalar/ACDCE.h:2
@@ +1,3 @@
+//===- ACDCE.h - Aggressive dead code elimination
+//--------------------------===//
+//
----------------
////===- ACDCE.h - Aggressive CONTROL dead code elimination--------===////





================
Comment at: lib/Transforms/Scalar/ACDCE.cpp:2
@@ +1,3 @@
+//===- ACDCE.cpp - Code to perform dead code elimination
+//-------------------===//
+//
----------------
Please fix the banner.


http://reviews.llvm.org/D18762





More information about the llvm-commits mailing list