[PATCH] D19518: Add optimization bisect opt-in calls for NVPTX passes

Jingyue Wu via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 11:00:56 PDT 2016


jingyue requested changes to this revision.
jingyue added a comment.
This revision now requires changes to proceed.

Oh, I see what you mean now.

So NVPTXPeephole should be guarded by `CodeGenOpt::None` and thus is safe to skip.

`NVPTXLowerKernelArgs` is unsafe to skip. See my inlined comments.


================
Comment at: lib/Target/NVPTX/NVPTXLowerKernelArgs.cpp:196
@@ -195,1 +195,3 @@
 bool NVPTXLowerKernelArgs::runOnFunction(Function &F) {
+  if (skipFunction(F))
+    return false;
----------------
handleByValParam is necessary for correctness, so NVPTXLowerKernelArgs can't be skipped unless we separate handleByValParam out to another pass. 


Repository:
  rL LLVM

http://reviews.llvm.org/D19518





More information about the llvm-commits mailing list