[PATCH] D18996: [PPC] Enable shuffling of VSX vectors

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:11928
@@ -11927,1 +11927,3 @@
 
+  if (Subtarget.hasVSX())
+    return true;
----------------
I agree that this makes sense. I was going to ask that you combine this with the v2i64 logic above, and add appropriate checks for VSX data types, however, since this shouldn't have any effect on scalarized types, it is not clear that the type checks here are actually useful. Maybe just simplify this to read:

  if (Subtarget.hasVSX() || Subtarget.hasQPX())
    return true;

  return TargetLowering::shouldExpandBuildVectorWithShuffles(VT, DefinedValues);



http://reviews.llvm.org/D18996