[PATCH] D19487: [LV] Reallow interleaved load groups with gaps

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 07:34:06 PDT 2016


sbaranga added a comment.

In http://reviews.llvm.org/D19487#412076, @sbaranga wrote:

> In http://reviews.llvm.org/D19487#412065, @mssimpso wrote:
>
> > > I might be missing something obvious, but why is TC >= Step if TC % Step is 0?
> >
> >
> > Sorry, I didn't mean for that to read as an implication. The minimum iterations check is supposed to ensure that TC >= Step. We can add the check for TC is not zero, but I think instcombine will probably remove it. What do you think?
>
>
> Do you mean the emitMinimumIterationCountCheck? Looks like the minimum check is using whatever getOrCreateVectorTripCount returns, so it probably won't work as expected. I think checking for the zero case here would be ok.


Sorry, I misread that. It's using the actual trip count, so this should be ok.


http://reviews.llvm.org/D19487





More information about the llvm-commits mailing list