[PATCH] D19494: [ELF] Introduce --reproduce flag

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: ELF/Driver.cpp:259
@@ +258,3 @@
+  for (unsigned I = 1, E = Args.size(); I < E; ++I)
+    OS << " " << Args[I];
+  OS << "\n";
----------------
ruiu wrote:
> silvas wrote:
> > An argument might contain a space, so let's separate these by newlines instead.
> > (an argument can technically contain a newline but I think that's sufficiently rare that we don't need to worry about that in a first patch.)
> Pathname with spaces are also rare (except on Windows), no? An upside of writing all options in one line is you can (re-)execute the command just by passing the file to the shell.
> Pathname with spaces are also rare (except on Windows), no?

Exactly. Windows is one of our supported platforms.

> An upside of writing all options in one line is you can (re-)execute the command just by passing the file to the shell.

For now, let's go ahead with how Davide had it (one line). We can make this more robust in future patches.



Repository:
  rL LLVM

http://reviews.llvm.org/D19494