[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 14:58:25 PDT 2016


xur updated this revision to Diff 54915.
xur added a comment.

Addressed some of the David's most recently comments:
(1) comments change
(2) inline fixupInvokeInst into promote(). After this change, we no longer need the direct-call instruction. So I changed createDirectCallInst() to return the new instruction (either is direct-call or the result-cast). 
(3) simplify the test case for the covariant return for call. 
(4) add a test case for covariant return for invoke.


http://reviews.llvm.org/D17864

Files:
  include/llvm/InitializePasses.h
  include/llvm/LinkAllPasses.h
  include/llvm/Transforms/Instrumentation.h
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Instrumentation/CMakeLists.txt
  lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  lib/Transforms/Instrumentation/Instrumentation.cpp
  test/Transforms/PGOProfile/icp_covariant_call_return.ll
  test/Transforms/PGOProfile/icp_covariant_invoke_return.ll
  test/Transforms/PGOProfile/icp_invoke.ll
  test/Transforms/PGOProfile/icp_mismatch_msg.ll
  test/Transforms/PGOProfile/icp_vararg.ll
  test/Transforms/PGOProfile/indirect_call_promotion.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17864.54915.patch
Type: text/x-patch
Size: 47500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/ebb88487/attachment.bin>


More information about the llvm-commits mailing list