[test-suite] r267439 - [test-suite] Set unique prefix for Vector and Vector/NEON

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 13:06:32 PDT 2016


The prefix is set it based on directly name.
Altivec is another directory under Vector and has nothing to do with this
change. Setting prefix to Altivec here would apply it to all files in
Vector/ and subdirectories underneath which is probably not what you had in
mind.

We could add Altivec prefix in Vector/Altivec/CMakeLists.txt which would
set Altivec prefix for all tests in that directory.

--Artem

On Mon, Apr 25, 2016 at 12:23 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 25 April 2016 at 19:42, Artem Belevich via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > +llvm_target_prefix("Vector")
> >  if(ARCH STREQUAL "PowerPC")
> >    llvm_add_subdirectories(Altivec)
> >  endif()
> >
> > +llvm_target_prefix("Vector-NEON")
> >  list(APPEND CFLAGS -std=c99)
> >  llvm_singlesource()
>
> Nitpick, couldn't this be "Altivec" and "NEON", instead?
>
> "Vector" just seems too generic. :)
>
> cheers,
> --renato
>



-- 
--Artem Belevich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/8ec9b131/attachment.html>


More information about the llvm-commits mailing list