[PATCH] D19255: [ppc64] fix bug in prologue that mfocrf's cr operand should be explict state instead of implicit

Mon Apr 25 12:35:10 PDT 2016

kbarton added inline comments.

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:846
@@ -845,2 +845,3 @@
     unsigned MfcrOpcode = PPC::MFCR8;
-    if (isELFv2ABI && MustSaveCRs.size() == 1)
+    unsigned CrState = RegState::ImplicitKill;
+    if (isELFv2ABI && MustSaveCRs.size() == 1) {
----------------
Why does this need to be put into a variable? I only see it used once below - can you not just put RegState::ImplicitKill directly in the MIB.addReg call below?


http://reviews.llvm.org/D19255



