[llvm] r267415 - Fix incorrect redundant expression in target AMDGPU.

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 08:06:34 PDT 2016


Author: etienneb
Date: Mon Apr 25 10:06:33 2016
New Revision: 267415

URL: http://llvm.org/viewvc/llvm-project?rev=267415&view=rev
Log:
Fix incorrect redundant expression in target AMDGPU.

Summary:
The expression is detected as a redundant expression.
Turn out, this is probably a bug.

```
/home/etienneb/llvm/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:306:26: warning: both side of operator are equivalent [misc-redundant-expression]
  if (isSMRD(*FirstLdSt) && isSMRD(*FirstLdSt)) {
```

Reviewers: rnk, tstellarAMD

Subscribers: arsenm, cfe-commits

Differential Revision: http://reviews.llvm.org/D19460

Modified:
    llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp?rev=267415&r1=267414&r2=267415&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp Mon Apr 25 10:06:33 2016
@@ -303,7 +303,7 @@ bool SIInstrInfo::shouldClusterMemOps(Ma
     SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::vdst);
   }
 
-  if (isSMRD(*FirstLdSt) && isSMRD(*FirstLdSt)) {
+  if (isSMRD(*FirstLdSt) && isSMRD(*SecondLdSt)) {
     FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::sdst);
     SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::sdst);
   }




More information about the llvm-commits mailing list