[llvm] r267350 - [X86][SSE] getTargetShuffleMaskIndices - dropped (unused) UNDEF handling

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 24 09:49:54 PDT 2016


Author: rksimon
Date: Sun Apr 24 11:49:53 2016
New Revision: 267350

URL: http://llvm.org/viewvc/llvm-project?rev=267350&view=rev
Log:
[X86][SSE] getTargetShuffleMaskIndices - dropped (unused) UNDEF handling

We aren't currently making use of this in any successful mask decode and its actually incorrect as it inserts the wrong number of SM_SentinelUndef mask elements.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=267350&r1=267349&r2=267350&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sun Apr 24 11:49:53 2016
@@ -4731,11 +4731,6 @@ static bool getTargetShuffleMaskIndices(
     return false;
 
   for (SDValue Op : MaskNode->ops()) {
-    if (Op.isUndef()) {
-      RawMask.push_back((uint64_t)SM_SentinelUndef);
-      continue;
-    }
-
     if (auto *CN = dyn_cast<ConstantSDNode>(Op.getNode()))
       SplitElementToMask(CN->getAPIntValue());
     else if (auto *CFN = dyn_cast<ConstantFPSDNode>(Op.getNode()))




More information about the llvm-commits mailing list