[lld] r267314 - ELF: Always include undefined DSO symbols in the symbol table.

[Peter Collingbourne via llvm-commits]

Author: pcc
Date: Sat Apr 23 21:31:02 2016
New Revision: 267314

URL: http://llvm.org/viewvc/llvm-project?rev=267314&view=rev
Log:
ELF: Always include undefined DSO symbols in the symbol table.

Fixes check-llvm when bootstrapping.

Also remove mostly dead and most likely incorrect logic regarding preemption
of weak undefined symbols.

Added:
    lld/trunk/test/ELF/undef-version-script.s
Modified:
    lld/trunk/ELF/Symbols.cpp

Modified: lld/trunk/ELF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=267314&r1=267313&r2=267314&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.cpp (original)
+++ lld/trunk/ELF/Symbols.cpp Sat Apr 23 21:31:02 2016
@@ -123,13 +123,9 @@ bool SymbolBody::isPreemptible() const {
   if (!Config->Shared)
     return false;
 
-  // Undefined symbols in DSOs can only be preempted if they are strong.
-  // Weak symbols just resolve to zero.
-  if (isUndefined())
-    return !isWeak();
-
   // -Bsymbolic means that not even default visibility symbols can be preempted.
-  if (Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc()))
+  if ((Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc())) &&
+      isDefined())
     return false;
 
   // Only default visibility symbols that appear in the dynamic symbol table can
@@ -323,7 +319,8 @@ std::string elf::demangle(StringRef Name
 bool Symbol::includeInDynsym() const {
   if (Visibility != STV_DEFAULT && Visibility != STV_PROTECTED)
     return false;
-  return (ExportDynamic && VersionScriptGlobal) || Body->isShared();
+  return (ExportDynamic && VersionScriptGlobal) || Body->isShared() ||
+         Body->isUndefined();
 }
 
 template uint32_t SymbolBody::template getVA<ELF32LE>(uint32_t) const;

Added: lld/trunk/test/ELF/undef-version-script.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/undef-version-script.s?rev=267314&view=auto
==============================================================================
--- lld/trunk/test/ELF/undef-version-script.s (added)
+++ lld/trunk/test/ELF/undef-version-script.s Sat Apr 23 21:31:02 2016
@@ -0,0 +1,37 @@
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: echo "{ local: *; };" > %t.script
+# RUN: ld.lld --version-script %t.script -shared %t.o -o %t.so
+# RUN: llvm-readobj -dyn-symbols %t.so | FileCheck %s
+
+# CHECK:      DynamicSymbols [
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: @ (0)
+# CHECK-NEXT:     Value: 0x0
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Local (0x0)
+# CHECK-NEXT:     Type: None (0x0)
+# CHECK-NEXT:     Other: 0
+# CHECK-NEXT:     Section: Undefined (0x0)
+# CHECK-NEXT:   }
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: bar@ (1)
+# CHECK-NEXT:     Value: 0x0
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Weak (0x2)
+# CHECK-NEXT:     Type: None (0x0)
+# CHECK-NEXT:     Other: 0
+# CHECK-NEXT:     Section: Undefined (0x0)
+# CHECK-NEXT:   }
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: foo@ (5)
+# CHECK-NEXT:     Value: 0x0
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Global (0x1)
+# CHECK-NEXT:     Type: None (0x0)
+# CHECK-NEXT:     Other: 0
+# CHECK-NEXT:     Section: Undefined (0x0)
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
+.global foo
+.weak bar