[PATCH] D19407: [SafeStack] [SSP] Use llvm.stackguard intrinsic.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 13:51:28 PDT 2016


timshen added a comment.

In http://reviews.llvm.org/D19407#409330, @eugenis wrote:

> I wonder if we could get SDAG SSP for free now by updating the following code to look at SafeStack, too:
>  getAnalysis<StackProtector>().shouldEmitSDCheck(*LLVMBB)


I'm not familiar with SafeStack, but SafeStack SSP does have a different type of canary, right? Then this line will crash: https://github.com/llvm-mirror/llvm/blob/ac94d4bd341c54f663f9622357da7eaad905a7c9/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp#L5336


Repository:
  rL LLVM

http://reviews.llvm.org/D19407





More information about the llvm-commits mailing list