[PATCH] D19404: Reorganize GlobalValueSummary with a "Flags" bitfield.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 13:06:02 PDT 2016


tejohnson added a comment.

In http://reviews.llvm.org/D19404#409415, @joker.eph wrote:

> Indeed, great suggestion!
>
> But now that I think about it, we have a global "epoch" number that I added recently in the bitcode (see IDENTIFICATION_BLOCK_ID). We could bump it when needed.


If we use this it will need to be emitted into the combined index as well (it isn't currently - easy enough to do).

The only issue with that is that I would expect more "churn" at least for awhile with the summary format, not sure if it is a big deal to have the epoch bump frequently due to that. Otherwise seems fine to me.


http://reviews.llvm.org/D19404





More information about the llvm-commits mailing list