[PATCH] D19419: [ELF] - Implemented comparsion operators for linkerscript

[Ed Maste via llvm-commits]

emaste added inline comments.

================
Comment at: ELF/LinkerScript.cpp:152
@@ -135,1 +151,3 @@
+  if (Op == "!=")
+    return L == R ? 0 : 1;
   llvm_unreachable("invalid operator");
----------------
Trivial comment, but why not `L != R` here? And, why not just `return L < R;`, `return L > R;` etc. in general? For me at least `? 1 : 0` is not any more clear/readable.



http://reviews.llvm.org/D19419