[PATCH] D19332: [ELF] - implemented ternary operator for linkerscript expressions

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 03:42:13 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:138
@@ +137,3 @@
+    if (Op1 == "?")
+      return parseTernary(Tokens, Lhs, Dot);
+
----------------
ruiu wrote:
> Swap Tokens and Lhs so that the order matches with parseExpr1.
r267086 changed signature to:
```
uint64_t LinkerScript<ELFT>::parseExpr1(ArrayRef<StringRef> &Tokens,
                                        uint64_t Lhs, int MinPrec) {

```
So leaved without changes the order.
But I made it a member of class and changed signature to:

```
uint64_t LinkerScript<ELFT>::parseTernary(ArrayRef<StringRef> &Tokens, uint64_t Cond)
```
(to match latest changes about Dot)


Repository:
  rL LLVM

http://reviews.llvm.org/D19332





More information about the llvm-commits mailing list