[PATCH] D19353: [GVN] Replace an inverted comparison with a logical not

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 21:58:23 PDT 2016


My suggestion, given the comments on this thread, would be for someone to
make a decision (or build a consensus) on what the canonical form of this
kind of thing should look like, and then we just go and make everything do
that :P, whether it's the result david has produced, or compare over
compare, or whatever.


On Thu, Apr 21, 2016 at 11:00 AM, Geoff Berry <gberry at codeaurora.org> wrote:

> gberry added a comment.
>
> @reames I believe CodeGenPrepare::SinkCmpExpressions already takes care of
> this.
>
> @mcrosier I would guess that any cond branches that have not(c) as their
> condition would get simplified to use just 'c' and swap the branch targets,
> so I don't think this would impact the optimizations you mentioned.
>
>
> http://reviews.llvm.org/D19353
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160421/a766ddb3/attachment.html>


More information about the llvm-commits mailing list