[PATCH] D19388: [MemorySSA] Fix bug in CachingMemorySSAWalker::invalidateInfo

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 14:34:14 PDT 2016


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM with one nit. Thank you!


================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:759
@@ -758,1 +758,3 @@
                                 const MemoryLocation &Loc) const;
+#ifdef XDEBUG
+  void verifyRemoved(MemoryAccess *);
----------------
It might be useful to be able to call this e.g. directly from GDB, so can we relax this to if `NDEBUG` isn't defined? (To be clear, I agree that the automatic check on removal should happen iff `XDEBUG` is given)


http://reviews.llvm.org/D19388





More information about the llvm-commits mailing list