[PATCH] D19333: Move coverage related code into a separate library

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 13:15:22 PDT 2016


I'm not sure. This feels like it's just papering over a bigger problem
with the layering. Unfortunately I haven't been following some of the
other profiling changes close enough to have a well formed opinion at
the moment.

The really annoying part about this is that AFAICT the problematic edge
in the dependency graph is entirely accidental. Coverage wants to read
object files but doesn't particularly care about bitcode, so the
Object->Bitcode dependency is annoying. Even then, I believe Object only
reads Bitcode and doesn't write, but the Bitcode->Analysis dependency is
only in the BitcodeWriter...

Easwaran Raman <eraman at google.com> writes:
> eraman added a comment.
>
> Justin, does this look good?
>
>
> http://reviews.llvm.org/D19333


More information about the llvm-commits mailing list