[PATCH] D19364: [ELF] - Implemented linkerscript ALIGN command

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 08:35:21 PDT 2016


grimar added inline comments.

================
Comment at: test/ELF/linkerscript-align.s:9
@@ +8,3 @@
+# RUN:   *(.aaa) \
+# RUN:  } \
+# RUN:  . = ALIGN(4096); \
----------------
rafael wrote:
> Any reason for not just checking in the script in Inputs?
All (or at least most of) our tests has scripts inline atm. Actually I think it is
comfortable to have it in the same file. We have files with dozen
of little scripts, I don't think have dozen of inputs for them is better.


http://reviews.llvm.org/D19364





More information about the llvm-commits mailing list