[PATCH] D19167: [esan] EfficiencySanitizer instrumentation pass

[Filipe Cabecinhas via llvm-commits]

filcab added inline comments.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:323
@@ +322,3 @@
+    return -1;
+  }
+  size_t Idx = countTrailingZeros(TypeSizeBytes);
----------------
filcab wrote:
> Polluting output too much is annoying. Thinking about it, I guess we might hit this on most runs, not just rarely, which makes it less useful.
> How about doing something like ASan does in instrumentUnusualSizeOrAlignment?
> 
Or just add an `__esan_{un,}aligned_load_n` function which we call with addr and size, and then we can figure out the fastpath later (which depends on the tool anyway).


http://reviews.llvm.org/D19167