[PATCH] D19343: Move PDB parsing code into a library

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 14:44:49 PDT 2016


zturner created this revision.
zturner added a reviewer: rnk.
zturner added a subscriber: llvm-commits.

PDB parsing code was hand-rolled into llvm-pdbdump.  This patch moves the parsing of this code into DebugInfoPDB and makes the dumper use this.

This is achieved by implementing the skeleton of RawPdbSession, the non-DIA counterpart to the existing PDB read interface.  None of the type / source file / etc information is accessible yet, so this implementation is not yet close to achieving parity with the DIA counterpart, but the `RawSession` class simply holds a reference to a `PDBFile` class which handles parsing the file format.  Additionally a `PDBStream` class is introduced which allows accessing the bytes of a particular stream in a PDB file.

Feel free to add another reviewer if you can think of someone better.

http://reviews.llvm.org/D19343

Files:
  include/llvm/DebugInfo/PDB/IPDBSession.h
  include/llvm/DebugInfo/PDB/PDBTypes.h
  include/llvm/DebugInfo/PDB/Raw/PDBFile.h
  include/llvm/DebugInfo/PDB/Raw/PDBStream.h
  include/llvm/DebugInfo/PDB/Raw/RawSession.h
  lib/DebugInfo/PDB/CMakeLists.txt
  lib/DebugInfo/PDB/PDB.cpp
  lib/DebugInfo/PDB/Raw/PDBFile.cpp
  lib/DebugInfo/PDB/Raw/PDBStream.cpp
  lib/DebugInfo/PDB/Raw/RawSession.cpp
  tools/llvm-pdbdump/BuiltinDumper.h
  tools/llvm-pdbdump/llvm-pdbdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19343.54424.patch
Type: text/x-patch
Size: 49831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160420/3c1a3c15/attachment.bin>


More information about the llvm-commits mailing list