[PATCH] D19171: [ELF] - Get rid of SectionOrder array.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 13:35:35 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:93
@@ -92,1 +92,3 @@
 
+uint32_t LinkerScript::getSectionOrder(StringRef Name) {
+  auto Begin = Locations.begin();
----------------
The return value will never overflow in reality, so let's use just int instead of uint32_t. Then you can report the absent key as just -1 instead of UINT32_MAX.


http://reviews.llvm.org/D19171





More information about the llvm-commits mailing list