[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

Derek Bruening via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 11:41:27 PDT 2016


bruening added inline comments.

================
Comment at: lib/esan/esan.h:38-40
@@ +37,5 @@
+
+void initializeLibrary();
+int finalizeLibrary();
+void processMemAccess(uptr PC, uptr Addr, int Size, bool IsWrite);
+void processUnalignedAccess(uptr PC, uptr Addr, int Size, bool IsWrite);
----------------
aizatsky wrote:
> kubabrecka wrote:
> > All the other sanitizers use capitalized function names (with the first letter capitalized as well).  Can we do this in ESan as well?  E.g. `InitializeLibrary`, `FinalizeLibrary`, `ProcessMemAccess`, etc.
> Chandler asked us specifically to adhere to LLVM coding and naming guidelines. 
Right, I talked to Kostya about this before and he asked for new files to use LLVM standards, while the existing files would remain internally consistent with their current style.


http://reviews.llvm.org/D19168





More information about the llvm-commits mailing list