[PATCH] D17740: [PPC, SSP] Support PowerPC Linux stack protection using LOAD_STACK_GUARD

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 13:18:25 PDT 2016


timshen added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12017
@@ +12016,3 @@
+
+bool PPCTargetLowering::useLoadStackGuardNode() const {
+  if (!Subtarget.isTargetLinux()) {
----------------
echristo wrote:
> Comment explaining why on all 3 of these functions please.
Through commenting the functions, I actually simplifies them by overriding only two of them. :)

================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1860
@@ -1859,1 +1859,3 @@
 
+bool PPCInstrInfo::expandPostRAPseudo(MachineBasicBlock::iterator MI) const {
+  switch (MI->getOpcode()) {
----------------
echristo wrote:
> Comments.
Done in the header.


http://reviews.llvm.org/D17740





More information about the llvm-commits mailing list