[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/esan/esan.h:21
@@ +20,3 @@
+//   - No system headers included in header files (*).
+//   - Platform specific headres included only into platform-specific files (*).
+//
----------------
typo: headers

================
Comment at: lib/esan/esan.h:32
@@ +31,3 @@
+
+#define CALLERPC ((uptr)__builtin_return_address(0))
+
----------------
sanitizer_internal_defs.h:# define GET_CALLER_PC() (uptr)__builtin_return_address(0)


================
Comment at: lib/esan/esan_interface.h:14
@@ +13,3 @@
+// module.
+// This header can be included by the instrumented program or by esan tests.
+//===----------------------------------------------------------------------===//
----------------
If this is meant to be included by the instrumented program, it should go under include/sanitizer. And not use sanitizer_internal_defs.h.


http://reviews.llvm.org/D19168