[PATCH] D19263: Enable ODR uniquing of DITypes in more places

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 08:38:00 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:524
@@ -523,2 +523,3 @@
         Context.setDiscardValueNames(LTODiscardValueNames);
+        Context.enableDebugTypeODRUniquing();
 
----------------
This is the "CodeGen only" loop, won't import anything I  don't think it matters here, but see below.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:577-578
@@ -575,4 +576,4 @@
       Pool.async([&](int count) {
         LLVMContext Context;
         Context.setDiscardValueNames(LTODiscardValueNames);
         auto ModuleIdentifier = ModuleBuffer.getBufferIdentifier();
----------------
Here instead?


http://reviews.llvm.org/D19263





More information about the llvm-commits mailing list