[PATCH] D19237: ELF: Add +, -, *, / and & to SECTIONS linker script command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 08:15:50 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19237#405107, @ruiu wrote:

> The operator precedence parsing is a pretty popular parsing technique to parse an operator-precedence grammar. Of course I didn't invent it, and it is not the first time for me to write it; it is a well known and well understood technique which is described in compiler textbooks. It's probably not an unreasonable assumption that readers already know it. I believe that the algorithm is usually the first choice when you are to parse an arithmetic expression, so I wonder why you want to do that differently.


I have no doubt its popular and was used in many compilers, I just find this implementation so straightforward due to lots of cross calls and recursion in compare with my version. And I really see no benefits to use it then.


http://reviews.llvm.org/D19237





More information about the llvm-commits mailing list