[PATCH] D18986: [ThinLTO] Prevent importing of "llvm.used" values

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 15:57:14 PDT 2016


joker.eph added inline comments.

================
Comment at: include/llvm/IR/Module.h:752
@@ -750,1 +751,3 @@
 
+/// \brief Given "llvm.used" or "llvm.compiler.used" as a global name, collect
+/// the initializer elements of that global in Set and return the global itself.
----------------
(Remove brief).

================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:219
@@ +218,3 @@
+    if (!V->hasLocalLinkage())
+      continue;
+    // We would have blocked importing from this module by suppressing index
----------------
I feel we should check `GlobalsToImport` here, the client has the ability to ask for promotion for specific symbols right? 


http://reviews.llvm.org/D18986





More information about the llvm-commits mailing list