[PATCH] D19222: Restructuring changes in preparation for enabling the x86 call frame optimization for 64-bit targets

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/Target/X86/X86CallFrameOptimization.cpp:109-110
@@ -109,1 +108,4 @@
+  MachineRegisterInfo *MRI;
+  unsigned StackSlotSize;
+  unsigned Log2StackSlotSize;
   static char ID;
----------------
Total bikeshedding: I think you can omit "Stack" and use SlotSize and Log2SlotSize. If you grep around LLVM for SlotSize, you'll find that this variable name is used very frequently with this meaning. It's nice to be consistent.


http://reviews.llvm.org/D19222