[PATCH] D19226: [X86] enable PIE for functions

[Reid Kleckner via llvm-commits]

rnk added a comment.

Can you add a test for other linkages as Rafael asked?

> This is still missing a testcase for other linkages (weak_odr and weak at least).


I would test internal, weak, and weak_odr. Include them even if they generate calls through the PLT.


================
Comment at: ../llvmOrg/lib/Target/X86/X86Subtarget.cpp:148
@@ +147,3 @@
+unsigned char X86Subtarget::
+classifyGlobalFunctionReference(const GlobalValue *GV,
+                                const TargetMachine &TM, bool isFast) const {
----------------
ditto, run the formatter

================
Comment at: ../llvmOrg/lib/Target/X86/X86Subtarget.h:559
@@ +558,3 @@
+  /// for the current subtarget.
+  /// isFast - indicate fastLowerCall, ignore NonLazyBind attribute 
+  unsigned char classifyGlobalFunctionReference(const GlobalValue *GV,
----------------
Is this parameter really necessary? I expect you can remove it, even if you have to change a few test expectations.

================
Comment at: ../llvmOrg/lib/Target/X86/X86Subtarget.h:561
@@ +560,3 @@
+  unsigned char classifyGlobalFunctionReference(const GlobalValue *GV,
+                                                const TargetMachine &TM, bool isFast) const;
+
----------------
Run clang-format


Repository:
  rL LLVM

http://reviews.llvm.org/D19226