[PATCH] D19195: [Clang][AVX512][BuiltIn] Adding suppot to builtin for VPERMD and VPERMW instruction set

[Asaf Badouh via llvm-commits]

AsafBadouh added inline comments.

================
Comment at: lib/Headers/avx512fintrin.h:5642
@@ +5641,3 @@
+__builtin_ia32_permdi512_mask ((__v8di)( __X),( __I),\
+              (__v8di) _mm512_setzero_si512 (),\
+              (__mmask8) (-1));\
----------------

can you use _mm512_undefined_epi32() ?

================
Comment at: lib/Headers/avx512fintrin.h:5699
@@ +5698,3 @@
+                 (__v8di) __X,
+                 (__v8di) _mm512_setzero_si512 (),
+                 (__mmask8) -1);
----------------

can you use _mm512_undefined_epi32() ?

================
Comment at: lib/Headers/avx512fintrin.h:5754
@@ +5753,3 @@
+                 (__v16si) __X,
+                 (__v16si) _mm512_setzero_si512 (),
+                 (__mmask16) -1);
----------------
can you use _mm512_undefined_epi32() ?


================
Comment at: lib/Headers/avx512vlintrin.h:7849
@@ +7848,3 @@
+_mm256_mask_permutexvar_ps (__m256 __W, __mmask8 __U, __m256i __X,
+          __m256 __Y)
+{
----------------
the following are missing
_mm256_permutexvar_epi64,
_mm256_permutex_epi64,
_mm256_permutexvar_ps 
_mm256_permutexvar_epi32


http://reviews.llvm.org/D19195