[PATCH] D19137: [cfi] Support explicit sections for functions in cfi-icall.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 14:52:19 PDT 2016


eugenis added inline comments.

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:642
@@ -641,3 +641,1 @@
     report_fatal_error("Bit set element may not be thread-local");
-  if (OpGlobal->hasSection())
-    report_fatal_error("Bit set element may not have an explicit section");
----------------
pcc wrote:
> Instead of removing this check, please change it to allow functions but not global variables.
Good point, done.


Repository:
  rL LLVM

http://reviews.llvm.org/D19137





More information about the llvm-commits mailing list