[PATCH] D19174: [sanitizers] [SystemZ] Introduce sanitizer_linux_s390.cc.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 14:28:37 PDT 2016


kcc added a comment.

Thanks, I like this better. Added 2 comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:127
@@ -150,2 +126,3 @@
 }
+#endif
 
----------------
add  // not __s390__

================
Comment at: lib/sanitizer_common/sanitizer_linux_s390.cc:17
@@ +16,3 @@
+
+#if SANITIZER_LINUX && defined(__s390__)
+
----------------
I would prefer you if can define SANITIZER_S390 (or some such), similar to SANITIZER_MIPS 
and then use it everywhere instead of defined(__s390__)


Repository:
  rL LLVM

http://reviews.llvm.org/D19174





More information about the llvm-commits mailing list