[llvm] r266446 - [PR27284] Reverse the ownership between DICompileUnit and DISubprogram.

[Tobias Grosser via llvm-commits]

On 04/15/2016 11:16 PM, Adrian Prantl wrote:
>
>> On Apr 15, 2016, at 2:14 PM, Tobias Grosser <tobias at grosser.es> wrote:
>>
>> On 04/15/2016 10:53 PM, Adrian Prantl wrote:
>>> Hi Tobias,
>>>
>>> there is a python script to upgrade testcases attached to the PR:
>>> https://llvm.org/bugs/show_bug.cgi?id=27284
>>>
>>> Note that it only works for upgrading .ll testcases. If you have source testcases that check for IR, you’ll have to do it manually. The changes are:
>>> - DICompileUnit no longer has a list of subprograms:
>>> - DISubprogram has a unit: pointing back to the DICompileUnit
>>> - The output order of debug metadata is changed because the subprograms no longer are referenced by the CU.
>>>
>>> let me know if I can help with upgrading the testcases.
>>
>> Hi Adrian,
>>
>> your script worked great. I just had to run it once over the test cases (actually tree times as I missed some), and the bugs got fixed. So no further help is needed and the buildbots are green again.
>>
>> In case you have more such changes in the pipeline, it would be great if you could reference the relevant script from the commit message.
>
> commit 93d9fac22356feb523a37130351dea0d37964212
> Author: adrian <adrian at 91177308-0d34-0410-b5e6-96231b3b80d8>
> Date:   Fri Apr 15 15:57:41 2016 +0000
>
>      [PR27284] Reverse the ownership between DICompileUnit and DISubprogram.
>
> <...snip...>
>      Attached to https://llvm.org/bugs/show_bug.cgi?id=27284 is a python script
>      that updates LLVM IR testcases to the new format.
>
>      http://reviews.llvm.org/D19034
>      <rdar://problem/25256815>
>
> :-)

OK. All my fault. :( I just missed this.

>> You are obviously also very much invited to just directly change the Polly test cases for such trivial changes without any pre-commit review. If this would be possible, we could probably avoid a couple of buildbot error messages being sent out to random people.
>
> I will try to do this next time.

Very much appreciated. But obviously, with providing the script you 
already solved the bigger problem. If people would just see it.

Thanks again,
Tobias