[llvm] r266446 - [PR27284] Reverse the ownership between DICompileUnit and DISubprogram.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 14:14:06 PDT 2016


On 04/15/2016 10:53 PM, Adrian Prantl wrote:
> Hi Tobias,
>
> there is a python script to upgrade testcases attached to the PR:
> https://llvm.org/bugs/show_bug.cgi?id=27284
>
> Note that it only works for upgrading .ll testcases. If you have source testcases that check for IR, you’ll have to do it manually. The changes are:
> - DICompileUnit no longer has a list of subprograms:
> - DISubprogram has a unit: pointing back to the DICompileUnit
> - The output order of debug metadata is changed because the subprograms no longer are referenced by the CU.
>
> let me know if I can help with upgrading the testcases.

Hi Adrian,

your script worked great. I just had to run it once over the test cases 
(actually tree times as I missed some), and the bugs got fixed. So no 
further help is needed and the buildbots are green again.

In case you have more such changes in the pipeline, it would be great if 
you could reference the relevant script from the commit message. You are 
obviously also very much invited to just directly change the Polly test 
cases for such trivial changes without any pre-commit review. If this 
would be possible, we could probably avoid a couple of buildbot error 
messages being sent out to random people.

Best,
Tobias



More information about the llvm-commits mailing list