[PATCH] D18905: [ValueTracking] Improve isImpliedCondition for conditions with matching operands.

[Balaram Makam via llvm-commits]

bmakam added a comment.

Perhaps instcombine is a better place to catch this? I verified PR23333 could be catched by this approach. While improving http://reviews.llvm.org/D18841 I could handle PR23333 and almost all the cases mentioned in here except for test_gt, test_ltand test_eq.  I can easily handle these cases but I have currently limited http://reviews.llvm.org/D18841 to the immediate dominator of depth 1 in favor of walking the entire dominator tree for compile-time tradeoff. I am not sure which approach is better. Perhaps you could improve this to also handle PR23333 and other tests in http://reviews.llvm.org/D18841 or perhaps both solutions could co-exist.


http://reviews.llvm.org/D18905