[PATCH] D19159: [sanitizer] [SystemZ] Implement internal_clone.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 09:42:28 PDT 2016


koriakin added a comment.

In http://reviews.llvm.org/D19159#402595, @kcc wrote:

> General question: is SystemZ a variant of Linux? 
>  If not, such changes should not go to files named *_linux*.cc, instead they should go into separate files names *_systemz.cc
>  Same is true even if SystemZ *is* a Linux variant, but a significantly different from the regular one.
>
> More generally, please prefer a separate file to multiple #ifdefs.


SystemZ is a CPU (also known as z/Series, or s390x), not an OS.


Repository:
  rL LLVM

http://reviews.llvm.org/D19159





More information about the llvm-commits mailing list