[PATCH] D19133: Fix typing on generated LXV2DX/STXV2DX instructions

[Nirav Dave via llvm-commits]

niravd added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10368
@@ +10367,3 @@
+    DCI.AddToWorklist(N.getNode());
+    return DAG.getNode(ISD::MERGE_VALUES, dl, DAG.getVTList(VecTy, MVT::Other),
+                       N, Swap.getValue(1));
----------------
nemanjai wrote:
> Pardon my ignorance here, I just don't follow why we're adding this ISD::MERGE_VALUES node here.
Merge Value is an identity node that returns its inputs and is used to work around the fact that node replacements do not always result in a final node with constructing all the values in the correct way. Here replacing the load with a different load and a swap node was fine because they returned the same shape output (value, chain), but with the bitcast we need to make a new ephemeral node to hold the bitcast result and the swap node's chain value. 


http://reviews.llvm.org/D19133