[PATCH] D19107: [ELF] - Tweak sorting rules for output sections to place orphan sections at end.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 05:44:03 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19107#402346, @ruiu wrote:

> I'm confused. If you submit http://reviews.llvm.org/D18499, then there is actually no orphan sections internally because you append all orphan sections to end of the SectionOrder vector, no? Instead of updating the if conditional, shouldn't you just remove it or replace it with assertions?


http://reviews.llvm.org/D18499 does not touch SectionOrder vector. It appends orphans to Locations list only.
Probably you're right and it should update the SectionOrder vector too.


http://reviews.llvm.org/D19107





More information about the llvm-commits mailing list