[PATCH] D19133: Fix typing on generated LXV2DX/STXV2DX instructions

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 22:59:30 PDT 2016


nemanjai added a subscriber: wschmidt.
nemanjai added a comment.

Just one inline comment (actually a question for my understanding) and pending a test case, this LGTM. Perhaps @wschmidt would like to take a look as well.
I have also tested the patch with a double bootstrap build and it all works fine.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10368
@@ +10367,3 @@
+    DCI.AddToWorklist(N.getNode());
+    return DAG.getNode(ISD::MERGE_VALUES, dl, DAG.getVTList(VecTy, MVT::Other),
+                       N, Swap.getValue(1));
----------------
Pardon my ignorance here, I just don't follow why we're adding this ISD::MERGE_VALUES node here.


http://reviews.llvm.org/D19133





More information about the llvm-commits mailing list