[PATCH] D19109: [ELF] - Refactoring of end/edata/etext implementation.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 07:43:46 PDT 2016


grimar added inline comments.

================
Comment at: ELF/Symbols.h:393
@@ -392,1 +392,3 @@
 template <class ELFT> struct ElfSym {
+  typedef std::pair<DefinedRegular<ELFT> *, DefinedRegular<ELFT> *> LinkerSym;
+
----------------
rafael wrote:
> SymPair maybe?
Done.

================
Comment at: ELF/Writer.cpp:1665
@@ -1665,1 +1664,3 @@
   // _end is the first location after the uninitialized data region.
+  auto Assign = [](ElfSym<ELFT>::LinkerSym &Sym, uintX_t Val) {
+    if (Sym.first)
----------------
rafael wrote:
> This can be a static function, no need to make it a lambda.
Done.


Repository:
  rL LLVM

http://reviews.llvm.org/D19109





More information about the llvm-commits mailing list