[PATCH] D18622: Replace the use of MaxFunctionCount module flag

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 23:38:22 PDT 2016


davidxl added inline comments.

================
Comment at: lib/ProfileData/ProfileSummary.cpp:116
@@ +115,3 @@
+bool InstrProfSummary::operator==(ProfileSummary &Other) {
+  InstrProfSummary *OtherIPS = cast<InstrProfSummary>(&Other);
+  if (!OtherIPS)
----------------
dyn_cast

================
Comment at: unittests/ProfileData/ProfileSummaryTest.cpp:65
@@ +64,3 @@
+  EXPECT_TRUE(SPS == *ProfileSummary::getProfileSummary(&M2));
+  EXPECT_TRUE(IPS == *ProfileSummary::getProfileSummary(&M1));
+}
----------------
redundant line.


http://reviews.llvm.org/D18622





More information about the llvm-commits mailing list