[PATCH] D19081: Add LLVMGetAttrKindIDInContext in the C API in order to facilitate migration away from LLVMAttribute

[Jakob Bornecrantz via llvm-commits]

Wallbraker requested changes to this revision.
Wallbraker added a comment.
This revision now requires changes to proceed.

About the code:  
The function requires documentation. Is there a list of attributes somewhere? What does it return on failure? How long are the values returned valid? Per context, per thread, per process, per release?

About the plan: 
Since @whitequark also wanted to bump the ABI version of the KindID you might as well add of the new functions in one commit (new functions and keeping the old, yes its duplicated API but its only for one release).

Will target dependent attributes be covered by the API (like "no-sse")? Or is it only the regular attributes?


http://reviews.llvm.org/D19081