[PATCH] D18706: [DWARF] Force a linkage_name on an inlined subprogram's abstract origin

[David Blaikie via llvm-commits]

On Wed, Apr 13, 2016 at 2:54 PM, Paul Robinson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> probinson added a comment.
>
> In http://reviews.llvm.org/D18706#400343, @probinson wrote:
>
> > Try to do fewer lookups.
>
>
> This means every call to addLinkageName has to be guarded.  When I did the
> option originally (as an on/off), Eric was not a fan of guarding the calls,
> which is why it ended up inside the method. But now the condition is
> different in the two places that call the method, so maybe that's okay?
>

A, I hadn't spotted the other call. Your call, I'm OK either way.

- Dave


>
>
> http://reviews.llvm.org/D18706
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160413/af9e7a3f/attachment.html>