[PATCH] D19077: AMDGPU: Add skeleton GlobalIsel implementation

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.h:1
@@ +1,2 @@
+//===-- llvm/lib/Target/AMDGPU/AMDGPUCallLowering.h - Call lowering -----===//
+//
----------------
Missing -*- C++ -*-

================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.h:15
@@ +14,3 @@
+
+#ifndef LLVM_LIB_TARGET_AMDGPU_AMDGPUCALLLOWERING
+#define LLVM_LIB_TARGET_AMDGPU_AMDGPUCALLLOWERING
----------------
Missing _H

================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.h:28-29
@@ +27,4 @@
+
+  bool LowerReturn(MachineIRBuilder &MIRBuiler, const Value *Val,
+                   unsigned VReg) const override;
+  bool
----------------
Should probably update these to use the current start with lowercase naming convention while it's new

================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:112
@@ -109,1 +111,3 @@
 
+  /// This object will take onwership of \p GISelAccessor.
+  void setGISelAccessor(AMDGPUGISelAccessor &GISelAccessor) {
----------------
Typo onwership, although it seems like this comment would only go on the base class

================
Comment at: lib/Target/AMDGPU/CMakeLists.txt:19
@@ +18,3 @@
+     AMDGPUCallLowering.cpp
+     )
+
----------------
Weird indent


http://reviews.llvm.org/D19077